[ https://issues.apache.org/jira/browse/THRIFT-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146872#comment-15146872 ]
ASF GitHub Bot commented on THRIFT-3609: ---------------------------------------- Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/869#issuecomment-184042110 Great, you've killed them all. Will definitely merge it soon. > Remove or replace TestPortFixture.h > ----------------------------------- > > Key: THRIFT-3609 > URL: https://issues.apache.org/jira/browse/THRIFT-3609 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library, Test Suite > Reporter: John Sirois > Assignee: John Sirois > > Today 6 cpp lib tests use > [TestPortFixture.h|https://github.com/apache/thrift/blob/1f6e380c5d07686e4cd8c2b172300a1ba7fbd8b9/lib/cpp/test/TestPortFixture.h]. > THRIFT-3608 experimented with correcting one of these cases in > {{lib/cpp/test/SecurityTest.cpp}}, but a general cleanup should remove all > uses of static ports in the cpp tests to improve robustness and open the path > to parallel testing - at least in the cpp libs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)