[ https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240265#comment-15240265 ]
ASF GitHub Bot commented on THRIFT-3787: ---------------------------------------- Github user jamesreggio commented on a diff in the pull request: https://github.com/apache/thrift/pull/986#discussion_r59645180 --- Diff: lib/nodejs/lib/thrift/connection.js --- @@ -81,15 +81,7 @@ var Connection = exports.Connection = function(stream, options) { }); this.connection.addListener("error", function(err) { - // Only emit the error if no-one else is listening on the connection - // or if someone is listening on us - if (self.connection.listeners('error').length === 1 || - self.listeners('error').length > 0) { - self.emit("error", err); - } --- End diff -- This code doesn't make any sense; emitting `error` with no listeners is a no-op, so we might as well do it always. > Node.js Connection object doesn't handle errors correctly > --------------------------------------------------------- > > Key: THRIFT-3787 > URL: https://issues.apache.org/jira/browse/THRIFT-3787 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Reporter: James Reggio > Priority: Minor > > There are a handful of operation-ordering problems in the > Connection.prototype.connection_gone() method and its friends. > See the pull request for more details. -- This message was sent by Atlassian JIRA (v6.3.4#6332)