Thanks! On Mon, May 9, 2016 at 8:49 AM, James Reggio (JIRA) <j...@apache.org> wrote:
> > [ > https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276534#comment-15276534 > ] > > James Reggio commented on THRIFT-3787: > -------------------------------------- > > Oh interesting! I was not aware of that behavior. Thanks for pointing it > out. > > The code still seems a bit odd, particularly in the sense that the number > of 'error' event listeners on the underlying connection should always be > one, since the connection is a private object, and we attach precisely one > listener. > > That said, if this code generates exceptions/side-effects, I'll leave it > alone. Definitely don't want to unintentionally change that behavior. I'll > push an update to the branch and ping you. > > > Node.js Connection object doesn't handle errors correctly > > --------------------------------------------------------- > > > > Key: THRIFT-3787 > > URL: https://issues.apache.org/jira/browse/THRIFT-3787 > > Project: Thrift > > Issue Type: Bug > > Components: Node.js - Library > > Reporter: James Reggio > > Assignee: Randy Abernethy > > Priority: Minor > > > > There are a handful of operation-ordering problems in the > Connection.prototype.connection_gone() method and its friends. > > See the pull request for more details. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
