On Wed, Apr 13, 2016 at 7:54 PM, John Sirois <jsir...@apache.org> wrote:
> > > On Wed, Apr 13, 2016 at 7:51 PM, Jim King <jim.k...@simplivity.com> wrote: > >> I’m still looking for answers on pull request build failures. >> >> I have 2 or 3 PRs open right now and they’ve failed in the apache >> precommit builds for strange reasons. >> >> The apache internal builds seem to be failing. >> > > I think the answer is the breaks need a fixer; hopefully you can find time > to help fix. > > I say this because I started down a series of patches to the java > codegen/lib a while back and found a similar state - though on the pull > request builder (apache jenkins). I stopped my java stuff and fixed that > CI with the help of Aki and Jake reviewing and providing guidance. I am > not a thrift comitter. > I will say that its discouraging that that CI is now solid red too: https://builds.apache.org/job/Thrift-precommit/ Part of the answer IMO is for committers to hold a hard line on accepting any patch, or pushing their own, w/o full green CIs. > > >> >> >> [image: Description: Description: simplivity-lg-xsmall] >> >> James E. King, III >> >> Architect >> >> 8 Technology Drive, 2nd Floor >> Westborough, MA 01581-1756 >> >> Ph: 855-SVT-INFO >> >> >> >> >> ------------------------------ >> PRIVACY STATEMENT: >> This message is a PRIVATE communication. This message and all attachments >> are a private communication sent by SimpliVity and are considered to be >> confidential or protected by privilege. If you are not the intended >> recipient, you are hereby notified that any disclosure, copying, >> distribution or use of the information contained in or attached to this >> message is strictly prohibited. Please notify the sender of the delivery >> error by replying to this message, and then delete it from your system. >> For more information please visit http://www.simplivity.com >> ------------------------------ >> > >