[
https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299394#comment-15299394
]
Aki Sukegawa commented on THRIFT-3834:
--------------------------------------
This broke erlang test on CI. Can you look into it ?
https://travis-ci.org/apache/thrift/jobs/131767221
{code}
src/test_thrift_server.erl:110: record 'Xtruct' undefined
src/test_thrift_server.erl:114: variable 'String' is unbound
src/test_thrift_server.erl:115: variable 'Byte' is unbound
src/test_thrift_server.erl:116: variable 'I32' is unbound
src/test_thrift_server.erl:117: variable 'I64' is unbound
src/test_thrift_server.erl:122: record 'Xtruct2' undefined
src/test_thrift_server.erl:123: record 'Xtruct' undefined
src/test_thrift_server.erl:123: record 'Xtruct2' undefined
src/test_thrift_server.erl:162: record 'Insanity' undefined
src/test_thrift_server.erl:163: record 'Xtruct' undefined
src/test_thrift_server.erl:168: record 'Xtruct' undefined
src/test_thrift_server.erl:172: record 'Insanity' undefined
src/test_thrift_server.erl:177: record 'Insanity' undefined
src/test_thrift_server.erl:199: record 'Xtruct' undefined
src/test_thrift_server.erl:208: record 'Xception' undefined
src/test_thrift_server.erl:220: record 'Xception' undefined
src/test_thrift_server.erl:223: record 'Xception2' undefined
src/test_thrift_server.erl:227: record 'Xtruct' undefined
src/test_thrift_server.erl:163: Warning: variable 'Hello' is unused
src/test_thrift_server.erl:168: Warning: variable 'Goodbye' is unused
src/test_thrift_server.erl:172: Warning: variable 'Crazy' is unused
{code}
> Erlang namespacing and exception metadata
> -----------------------------------------
>
> Key: THRIFT-3834
> URL: https://issues.apache.org/jira/browse/THRIFT-3834
> Project: Thrift
> Issue Type: New Feature
> Components: Erlang - Compiler
> Reporter: Steve Cohen
> Assignee: Steve Cohen
> Fix For: 0.10.0
>
> Attachments: add_namespacing.patch
>
>
> The erlang modules generated by thrift cannot be namespaced, this change
> allows namespacing like in other thrift types.
> If Module A defines a struct S and Module B defines a struct S and Module A
> includes Module B, it will not compile. This change fixes that problem.
> If at all possible, I'd like this to get into 0.10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
