[
https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300751#comment-15300751
]
Steve Cohen commented on THRIFT-3834:
-------------------------------------
So I figured out how to run tests `make check`, so that's good.
The problem is that ThriftTest.thrift has the line `namespace * thrift.test`,
which makes our namespace thrift.test. This causes the tests to fail. I'm not
sure why the * namespace was used, that seems unintentional and if I may be so
bold, wrong. Tests, especially shared ones, should be explicit.
So, the problem is with the tests, normal usage that doesn't set the 'erl' or
'*' namespace will continue to work. I'll update the tests so that they expect
namespaced records.
> Erlang namespacing and exception metadata
> -----------------------------------------
>
> Key: THRIFT-3834
> URL: https://issues.apache.org/jira/browse/THRIFT-3834
> Project: Thrift
> Issue Type: New Feature
> Components: Erlang - Compiler
> Reporter: Steve Cohen
> Assignee: Steve Cohen
> Fix For: 0.10.0
>
> Attachments: add_namespacing.patch
>
>
> The erlang modules generated by thrift cannot be namespaced, this change
> allows namespacing like in other thrift types.
> If Module A defines a struct S and Module B defines a struct S and Module A
> includes Module B, it will not compile. This change fixes that problem.
> If at all possible, I'd like this to get into 0.10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
