Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1039#discussion_r71078548 --- Diff: compiler/cpp/src/audit/t_audit.cpp --- @@ -41,12 +41,12 @@ void thrift_audit_warning(int level, const char* fmt, ...) { void thrift_audit_failure(const char* fmt, ...) { va_list args; - fprintf(stderr, "[Thrift Audit Failure:%s] ", g_curpath.c_str()); + //fprintf(stderr, "[Thrift Audit Failure:%s] ", g_curpath.c_str()); va_start(args, fmt); vfprintf(stderr, fmt, args); va_end(args); fprintf(stderr, "\n"); - g_return_failure = true; + //g_return_failure = true; } --- End diff -- We cannot just undo others' warnings and exit value manipulation... I imagine there are some difficulties to keep these ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---