Github user dtmuller commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1039#discussion_r71325852
  
    --- Diff: compiler/cpp/test/CMakeLists.txt ---
    @@ -18,15 +18,15 @@
     #
     
     
    -# Find required packages
    -set(Boost_USE_STATIC_LIBS ON) # Force the use of static boost test 
framework
    -find_package(Boost 1.53.0 REQUIRED COMPONENTS unit_test_framework)
    -include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
    +if(${WITH_PLUGIN})
    +    # Find required packages
    +    set(Boost_USE_STATIC_LIBS ON) # Force the use of static boost test 
framework
    +    find_package(Boost 1.53.0 REQUIRED COMPONENTS unit_test_framework)
    +    include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
     
    -#Make sure gen-cpp files can be included
    -include_directories("${CMAKE_CURRENT_BINARY_DIR}")
    +    #Make sure gen-cpp files can be included
    +    include_directories("${CMAKE_CURRENT_BINARY_DIR}")
     
    -if(${WITH_PLUGIN})
    --- End diff --
    
    I'm not sure what you mean by that?!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to