[GitHub] thrift pull request #981: THRIFT-3038: fix up some volatiles in cpp

[jeking3]

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/981#discussion_r71095982
  
    --- Diff: lib/cpp/src/thrift/transport/TFileTransport.h ---
    @@ -352,7 +352,7 @@ class TFileTransport : public TFileReaderTransport, 
public TFileWriterTransport
     
       // To keep track of whether the buffer has been flushed
       Monitor flushed_;
    -  volatile bool forceFlush_;
    +  bool forceFlush_;
    --- End diff --
    
    Thanks for catching that - I pushed an update changing this to a 
boost::atomic<bool> type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---