Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/981
The default op=, and even the default conversion operators from atomic<T>
to T are fine.
@nsuke I would prefer we keep the access to TThreadPoolServer timeout
variables as seq_cst. The setter operations shouldn't ever be in performance
critical code, and the 'get' side of things is happening in an already slow
area. On x86, the getters will still turn into regular 'mov' operations. On
ARM, there will be a couple of memory barriers generated, but those shouldn't
be a huge deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
