Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1051#discussion_r71162579
--- Diff: lib/erl/src/thrift_compact_protocol.erl ---
@@ -355,7 +356,7 @@ read(This0, i64) ->
read(This0, double) ->
{This1, Bytes} = read_data(This0, 8),
case Bytes of
- {ok, <<Val:64/float-signed-big, _/binary>>} -> {This1, {ok, Val}};
+ {ok, <<Val:64/float-signed-little, _/binary>>} -> {This1, {ok, Val}};
--- End diff --
Why is "float" used here instead of "Double"? I don't know erlang; just
looking at line 222 above and expecting it to be similar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
