Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1051#discussion_r71166224
--- Diff: lib/erl/src/thrift_compact_protocol.erl ---
@@ -355,7 +356,7 @@ read(This0, i64) ->
read(This0, double) ->
{This1, Bytes} = read_data(This0, 8),
case Bytes of
- {ok, <<Val:64/float-signed-big, _/binary>>} -> {This1, {ok, Val}};
+ {ok, <<Val:64/float-signed-little, _/binary>>} -> {This1, {ok, Val}};
--- End diff --
@jeking3 thanks, good poinit. I've checked the
[doc](http://erlang.org/doc/programming_examples/bit_syntax.html) but couldn't
find any `double`.
> The type can be integer, float, or binary.
So I'll replace the other part with float and also unify the order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
