[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471349#comment-15471349 ]
ASF GitHub Bot commented on THRIFT-3921: ---------------------------------------- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 I can see cases where someone relying on the enumeration's numeric output today would have a breaking change that they cannot easily avoid here. Changes like this one, for example the one that added what() to thrift C++ generated exception code, have caused me headaches in the past when upgrading. This makes me wonder if we want to make things like this thrift-compiler-time optional. Not something we have to solve here, but a more general question to the maintainers. > C++ code should print enums as strings > -------------------------------------- > > Key: THRIFT-3921 > URL: https://issues.apache.org/jira/browse/THRIFT-3921 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler > Reporter: Vivek Jain > > THRIFT-2067 added {{operator<<}} to the C++ generated code, which is great, > but enums are printed as numbers rather than their string representation. It > would be great if the generated code printed them as a string instead. There > might be some backwards-compatibility concerns (if users have already defined > their own versions, then thrift's version would cause compile errors), not > sure how important you guys think those are. > Other thoughts/concerns? I am willing to work on a patch if no one else is > able to work on it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)