[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870699#comment-15870699 ]
ASF GitHub Bot commented on THRIFT-3921: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1194 THRIFT-3921 cpp library- optional operator ostream support for enumerations You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-3921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1194 ---- commit 570717279501ab1c0184ab76b93b8b35abae2914 Author: Vivek Jain <vi...@vivekja.in> Date: 2016-09-07T17:34:25Z THRIFT-3921 Add C++ ostream operator<< functions for enums commit 05012da4996455330a58f8664341d3d38beba758 Author: James E. King, III <jim.k...@simplivity.com> Date: 2017-02-16T20:23:42Z Merge branch 'THRIFT-3921' of https://github.com/viveksjain/thrift into THRIFT-3921 commit 777a98bf7506b26033f14976ff7cc1b63d1e1fde Author: James E. King, III <jim.k...@simplivity.com> Date: 2017-02-16T21:06:29Z THRIFT-3921: made initial implementation conform to THRIFT-4060 optional output and added unit tests ---- > C++ code should print enums as strings > -------------------------------------- > > Key: THRIFT-3921 > URL: https://issues.apache.org/jira/browse/THRIFT-3921 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler > Reporter: Vivek Jain > Assignee: James E. King, III > > THRIFT-2067 added {{operator<<}} to the C++ generated code, which is great, > but enums are printed as numbers rather than their string representation. It > would be great if the generated code printed them as a string instead. There > might be some backwards-compatibility concerns (if users have already defined > their own versions, then thrift's version would cause compile errors), not > sure how important you guys think those are. > Other thoughts/concerns? I am willing to work on a patch if no one else is > able to work on it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)