Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1103#discussion_r81525567
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) {
idMap_.insert(std::pair<const Thread::id_t, shared_ptr<Thread>
>((*ix)->getId(), *ix));
--- End diff --
I feel the changes in here are substantial and quite useful, in that I have
added tests and re-enabled a number of tests, and ctest on windows runs in
about a minute now. As for getting rid of idMap_ and canSleep, I see no reason
to keep them. As for 0.10.0, all of these changes are pretty substantial and I
don't know if they make it in or not. I think they are substantial
improvements in correctness and stability, and should be considered at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
