Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1103#discussion_r81470710
--- Diff: lib/cpp/src/thrift/concurrency/PosixThreadFactory.h ---
@@ -39,7 +39,14 @@ class PosixThreadFactory : public ThreadFactory {
/**
* POSIX Thread scheduler policies
*/
- enum POLICY { OTHER, FIFO, ROUND_ROBIN };
+ class Policy {
+ public:
+ enum value {
+ OTHER = 0,
+ FIFO = 1,
+ ROUND_ROBIN = 2
+ };
--- End diff --
I understand your point, although I wouldn't personally do this as it feels
fighting against language.
If we do this, IMO we should introduce implicit conversion from inner enum
to outer class to remove the `::value` in method signatures.
But I think it's completely separate issue and should be handled separately
from this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
