[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626349#comment-15626349
 ] 

ASF GitHub Bot commented on THRIFT-3301:
----------------------------------------

Github user bgould commented on the issue:

    https://github.com/apache/thrift/pull/1120
  
    Also one thing to note is that the Java code generated from following valid 
IDL will still fail to compile because the names match Java primitive types... 
I know of no way to avoid this problem:
    
    ```thrift
    struct int {
      1: i32 val
    }
    
    struct boolean {
      1: bool val
    }
    
    struct long {
      1: i64 val
    }
    
    struct short {
      1: i16 short
    }
    
    struct char {
      1: i16 val
    }
    
    struct Primitives {
      1: i32 int,
      2: i64 long,
      3: i16 short,
      4: bool boolean,
      5: i16 char
    }
    ```


> Java generated code uses imports that can lead to class name collisions with 
> IDL defined types
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3301
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3301
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2
>         Environment: Tested on Linux (Ubuntu 14) with Oracle JDK 8
>            Reporter: Alexander Volanis
>         Attachments: thrift-issue-3301.tgz
>
>
> The Java generator will produce Java classes with the following set of imports
> {code}
> import org.apache.thrift.scheme.IScheme;
> import org.apache.thrift.scheme.SchemeFactory;
> import org.apache.thrift.scheme.StandardScheme;
> import org.apache.thrift.scheme.TupleScheme;
> import org.apache.thrift.protocol.TTupleProtocol;
> import java.util.List;
> import java.util.ArrayList;
> import java.util.Map;
> import java.util.HashMap;
> import java.util.EnumMap;
> import java.util.Set;
> import java.util.HashSet;
> import java.util.EnumSet;
> import java.util.Collections;
> import java.util.BitSet;
> import java.nio.ByteBuffer;
> import java.util.Arrays;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> {code}
> Any one of the imported classes may cause a name conflict with generated code 
> that happens to define a same name class and uses such class as argument or 
> result to methods.
> The generated code should always use fully qualified references to the 
> classes when necessary and avoid all use of imports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)