[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627306#comment-15627306
]
Benjamin Gould commented on THRIFT-3301:
----------------------------------------
Upon further thought I think that the Java keyword problem could be solved by
prefixing identifiers with an underscore, similar to the method Jens mentioned
for C#. Such a solution might not be ideal, and I'm not sure it is necessarily
the best solution, but is probably better than generating code that will not
compile. I will spin off a new jira issue if one does not exist already
because this issue is about the imports in generated code, not Java keywords.
> Java generated code uses imports that can lead to class name collisions with
> IDL defined types
> ----------------------------------------------------------------------------------------------
>
> Key: THRIFT-3301
> URL: https://issues.apache.org/jira/browse/THRIFT-3301
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2
> Environment: Tested on Linux (Ubuntu 14) with Oracle JDK 8
> Reporter: Alexander Volanis
> Attachments: thrift-issue-3301.tgz
>
>
> The Java generator will produce Java classes with the following set of imports
> {code}
> import org.apache.thrift.scheme.IScheme;
> import org.apache.thrift.scheme.SchemeFactory;
> import org.apache.thrift.scheme.StandardScheme;
> import org.apache.thrift.scheme.TupleScheme;
> import org.apache.thrift.protocol.TTupleProtocol;
> import java.util.List;
> import java.util.ArrayList;
> import java.util.Map;
> import java.util.HashMap;
> import java.util.EnumMap;
> import java.util.Set;
> import java.util.HashSet;
> import java.util.EnumSet;
> import java.util.Collections;
> import java.util.BitSet;
> import java.nio.ByteBuffer;
> import java.util.Arrays;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> {code}
> Any one of the imported classes may cause a name conflict with generated code
> that happens to define a same name class and uses such class as argument or
> result to methods.
> The generated code should always use fully qualified references to the
> classes when necessary and avoid all use of imports.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
