[
https://issues.apache.org/jira/browse/THRIFT-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633916#comment-15633916
]
ASF GitHub Bot commented on THRIFT-3957:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1122
THRIFT-3957: TConnectedClient does not disconnect from clients when their
timeout is reached
Fix per patches posted to Thrift Jira
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1122
----
----
> TConnectedClient does not disconnect from clients when their timeout is
> reached.
> --------------------------------------------------------------------------------
>
> Key: THRIFT-3957
> URL: https://issues.apache.org/jira/browse/THRIFT-3957
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 1.0
> Reporter: Claudius Heine
> Attachments:
> 0001-cpp-TestServer-removed-while-loop-and-added-connecti.patch,
> 0002-cpp-server-TConnectedClient-Timeouts-are-disconnecti.patch
>
>
> When starting the TestServer with the first appended patch:
> {code}
> bin/TestServer --protocol=json --transport=http --server-type=thread-pool
> --port=9080
> {code}
> And connecting to it with this shell command:
> {code}
> wget --post-data='[' http://localhost:9080
> {code}
> The connection stays up for a long time. Making DOS attacks very easy,
> because at some point the server runs out of available client connections.
> The second appended patch fixes the issue in TConnectedClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
