[ 
https://issues.apache.org/jira/browse/THRIFT-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635065#comment-15635065
 ] 

ASF GitHub Bot commented on THRIFT-3957:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1122
  
    Looks like a build system issue:
    
    > Downloading unordered-containers-0.2.7.1...
    > Failed to install network-uri-2.6.1.0
    > Build log ( /root/.cabal/logs/network-uri-2.6.1.0.log ):
    > cabal: /root/.cabal/logs/network-uri-2.6.1.0.log: does not exist
    > Makefile:613: recipe for target 'all-local' failed
    > make[3]: *** [all-local] Error 1
    > make[3]: Leaving directory '/thrift/src/lib/hs'
    > Makefile:552: recipe for target 'all-recursive' failed
    > make[2]: *** [all-recursive] Error 1
    > make[2]: Leaving directory '/thrift/src/lib'
    > Makefile:635: recipe for target 'all-recursive' failed
    > make[1]: *** [all-recursive] Error 1
    > make[1]: Leaving directory '/thrift/src'
    > Makefile:548: recipe for target 'all' failed
    > make: *** [all] Error 2
    > The command "docker run --net=host -e BUILD_LIBS="$BUILD_LIBS" $BUILD_ENV 
-v $(pwd):/thrift/src -it thrift-build:$DISTRO build/docker/scripts/$SCRIPT 
$BUILD_ARG" exited with 2.
    
    Any way to kick another one, or can I merge?


> TConnectedClient does not disconnect from clients when their timeout is 
> reached.
> --------------------------------------------------------------------------------
>
>                 Key: THRIFT-3957
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3957
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3, 0.10.0
>            Reporter: Claudius Heine
>            Assignee: James E. King, III
>         Attachments: 
> 0001-cpp-TestServer-removed-while-loop-and-added-connecti.patch, 
> 0002-cpp-server-TConnectedClient-Timeouts-are-disconnecti.patch
>
>
> When starting the TestServer with the first appended patch:
> {code}
> bin/TestServer --protocol=json --transport=http --server-type=thread-pool 
> --port=9080
> {code}
> And connecting to it with this shell command:
> {code}
> wget --post-data='[' http://localhost:9080
> {code}
> The connection stays up for a long time. Making DOS attacks very easy, 
> because at some point the server runs out of available client connections.
> The second appended patch fixes the issue in TConnectedClient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to