[ 
https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661405#comment-15661405
 ] 

ASF GitHub Bot commented on THRIFT-3773:
----------------------------------------

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r87710644
  
    --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc ---
    @@ -0,0 +1,2553 @@
    +/*
    --- End diff --
    
    This particular file shares more than half of its content with existing 
t_swift_generator.cc.
    While we can certainly do this, alternative would be to add a flag into 
existing one.
    See Node.js generator where we have separate `lib/nodejs` directory but 
single t_js_generator.cc with `gen_node_` field.
    
    As the difference is often new separate method calls, such a merging might 
not introduce much of a clutter.
    What do you think ?


> Swift Library
> -------------
>
>                 Key: THRIFT-3773
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3773
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Swift - Library
>            Reporter: Thomas Bartelmess
>            Assignee: Chris Simpson
>
> We already have the option to generate Swift code in the Cocoa compiler, 
> however large parts of the (Objective-C) Cocoa Library still depend on Cocoa 
> and  Objective-C.
> It would be good to have a native Swift library that doesn't depend on the 
> Cocoa libraries.
> Design goals:
> - Fully compatible with the code that is currently generated by the Cocoa 
> compiler (both Objective-C and Swift).
> - Ability to run on Linux
> - Pure Swift, no Objective-C code.
> - No dependencies on closed source apple libraries
> - Keep the same interface, so that the library is compatible with the code 
> the current cocoa compiler generates
> - Better server support that the current Objective-C library.
> - Follow the new Swift packaging format to be compatible with the Swift 
> Package manager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to