[
https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767715#comment-15767715
]
ASF GitHub Bot commented on THRIFT-3773:
----------------------------------------
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@nsuke I've removed the attribution, will keep it in my personal Lib repo
thats used strictly for SPM integration. Fixed the error codes you mentioned
above.
I'll go ahead and merge the old cocoa generator in and put it behind a
flag. Ideally, users leveraging existing Swift 2.x Cocoa bindings are using
Cocoapods, and have a lock to the specific commit they're using. This isn't
always the case, but should serve at least a basic level of protection on their
client/library dependency side. From the Generator's perspective, it will be
completely broken unless they checkout the most recent commit before I merge
them (or change any build steps to use the new generator).
In terms of their existing code if they're extending the library or
inheriting from it, some of it may break given some of the interfaces have
changed towards Value-typed interfaces. Extensions should for the most part
operate properly so long as they're not calling changed interfaces. All of
this is of course purely speculative as I've not gone through the process of
trying to migrate. Long story short however there should be facilities to hit
old lib/generator when needed and given Swift is compiled, migrating code over
shouldn't introduce any breaking changes or unexpected behaviors.
> Swift Library
> -------------
>
> Key: THRIFT-3773
> URL: https://issues.apache.org/jira/browse/THRIFT-3773
> Project: Thrift
> Issue Type: New Feature
> Components: Swift - Library
> Reporter: Thomas Bartelmess
> Assignee: Chris Simpson
>
> We already have the option to generate Swift code in the Cocoa compiler,
> however large parts of the (Objective-C) Cocoa Library still depend on Cocoa
> and Objective-C.
> It would be good to have a native Swift library that doesn't depend on the
> Cocoa libraries.
> Design goals:
> - Fully compatible with the code that is currently generated by the Cocoa
> compiler (both Objective-C and Swift).
> - Ability to run on Linux
> - Pure Swift, no Objective-C code.
> - No dependencies on closed source apple libraries
> - Keep the same interface, so that the library is compatible with the code
> the current cocoa compiler generates
> - Better server support that the current Objective-C library.
> - Follow the new Swift packaging format to be compatible with the Swift
> Package manager
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
