GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1132
THRIFT-3348 PHP TCompactProtocol bool&int64 readvalue bug
TCompactProtocol always serializes boolean struct values as false, due
to a confusion between the internal compact type field representation
and the normal Thrift types.
There is also a slight mishandling of i64 values where -2^63 will
overflow and be converted to a float, even though it is representable as
a 64-bit int.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhaakhi/thrift THRIFT-3348
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1132
----
commit f6a0fb0480aa3fc2d6b69dd676b219cdf7b3e9a0
Author: HÃ¥kon Hitland <hakon.hitl...@zedge.net>
Date: 2016-11-17T15:59:30Z
THRIFT-3348 PHP TCompactProtocol bool&int64 readvalue bug
TCompactProtocol always serializes boolean struct values as false, due
to a confusion between the internal compact type field representation
and the normal Thrift types.
There is also a slight mishandling of i64 values where -2^63 will
overflow and be converted to a float, even though it is representable as
a 64-bit int.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
