Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94347166
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32 bonkType
}
--- End diff --
BTW, I just did a search for *.thrift files already using `type` across the
Thrift repo. Besides ThriftTest.thrift itself, there are quite a few more. So
if we put "type" into the global list, we will have to fix a whole lot of
existing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
