[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796266#comment-15796266
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r94489293
--- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
@@ -984,10 +988,13 @@ void t_erl_generator::export_types_string(string
name, int num) {
}
void t_erl_generator::export_function(t_function* tfunction, string
prefix) {
-
+ t_struct::members_type::size_type num =
tfunction->get_arglist()->get_members().size();
+ if (num > std::numeric_limits<int>().max()) {
--- End diff --
I'm getting a warning at ` if (num > std::numeric_limits<int>().max()) { `
in this file and also in the erlang generator (2 occurences):
`C4018: ">": Conflict between "signed" and "unsigned"`
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up. As part of
> cleaning these up, I found that additional compilers were also posting
> warnings.
> Acceptance Criteria:
> # I can build successfully with Visual Studio 2010 targeting x86 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x86 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 release mode
> with /WX (warnings are errors).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
