[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818667#comment-15818667 ]
ASF GitHub Bot commented on THRIFT-3873: ---------------------------------------- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1128 There was just one issue on linux; I reverted a change in TBufferTransports.h (I had converted an assert to an exception, but we can figure out what to do with asserts holistically in THRIFT-3978). Hopefully this will pass. I have built this on all flavors of Visual Studio 2010, 2012, 2013, 2015 in Debug and Release, Win32 and x64, and run the unit tests. I also built this on Ubuntu 14.04. The CI build will prove out any other issues. > Fix various compiler warnings when using VS2010 > ----------------------------------------------- > > Key: THRIFT-3873 > URL: https://issues.apache.org/jira/browse/THRIFT-3873 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.10.0 > Environment: VS2010, Windows > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > While verifying a defect I had to build the windows thrift C++ library and > found a number of compiler warnings that needed to be cleaned up. As part of > cleaning these up, I found that additional compilers were also posting > warnings. > Acceptance Criteria: > # I can build successfully with Visual Studio 2010 targeting x86 debug mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x86 release mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x64 debug mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x64 release mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x86 debug mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x86 release mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x64 debug mode > with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x64 release mode > with /WX (warnings are errors). -- This message was sent by Atlassian JIRA (v6.3.4#6332)