Github user hcorg commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1128#discussion_r95604812
  
    --- Diff: lib/cpp/src/thrift/windows/config.h ---
    @@ -36,6 +36,9 @@
     #define USE_BOOST_THREAD 1
     #endif
     
    +// Something that defines PRId64 is required to build
    +#define HAVE_INTTYPES_H 1
    +
    --- End diff --
    
    it's probably left-over from pre-cmake times: vstudio project included in 
repo did not generate any config.h, yet something had to be included...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to