Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1128#discussion_r88804989 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp --- @@ -375,7 +383,12 @@ void THeaderTransport::resetProtocol() { } uint32_t THeaderTransport::getWriteBytes() { - return wBase_ - wBuf_.get(); + ptrdiff_t wb = wBase_ - wBuf_.get(); + if (wb > std::numeric_limits<uint32_t>().max()) { + throw TTransportException(TTransportException::CORRUPTED_DATA, + "write size is unreasonable"); + } --- End diff -- I added apache::thrift::transport::safe_numeric_cast to the TTransportException header. I couldn't think of a better place to put it for now... I agree it simplifies the code in many places, and the transport code seems to be the code closest to the platform where these transform issues exist.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---