Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1186#discussion_r100565597
  
    --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
    @@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
             reuse_objects_ = true;
           } else if( iter->first.compare("option_type") == 0) {
             use_option_type_ = true;
    +      } else if( iter->first.compare("handle_runtime_exceptions") == 0) {
    --- End diff --
    
    Yep, should be added to the structure at the end of the file at the very 
least.
    
    It would be nice to have more comprehensive documentation on the java 
options for the compiler in the java runtime readme, perhaps... but getting it 
into the compiler's --help output is required as stated above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to