Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1186#discussion_r100586356
  
    --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
    @@ -3527,6 +3531,11 @@ void 
t_java_generator::generate_process_function(t_service* tservice, t_function
       indent(f_service_) << "  return " << ((tfunction->is_oneway()) ? "true" 
: "false") << ";" << endl;
       indent(f_service_) << "}" << endl << endl;
     
    +  indent(f_service_) << "@Override" << endl;
    +  indent(f_service_) << "protected boolean handleRuntimeExceptions() {" << 
endl;
    +  indent(f_service_) << "  return " << ((handle_runtime_exceptions_) ? 
"true" : "false") << ";" << endl;
    +  indent(f_service_) << "}" << endl << endl;
    --- End diff --
    
    why not simply `return handle_runtime_exceptions_`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to