[
https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886606#comment-15886606
]
ASF GitHub Bot commented on THRIFT-3921:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1204
THRIFT-3921: fix ostream definitions so they are not inline because it
confused template deduction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-3921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1204
----
commit 89c09f514fbac8a3e5019af1a19263399ae4f6f8
Author: James E. King, III <[email protected]>
Date: 2017-02-27T21:53:36Z
THRIFT-3921: fix ostream definitions so they are not inline because it
confused template deduction
----
> C++ code should print enums as strings
> --------------------------------------
>
> Key: THRIFT-3921
> URL: https://issues.apache.org/jira/browse/THRIFT-3921
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler
> Reporter: Vivek Jain
> Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> THRIFT-2067 added {{operator<<}} to the C++ generated code, which is great,
> but enums are printed as numbers rather than their string representation. It
> would be great if the generated code printed them as a string instead. There
> might be some backwards-compatibility concerns (if users have already defined
> their own versions, then thrift's version would cause compile errors), not
> sure how important you guys think those are.
> Other thoughts/concerns? I am willing to work on a patch if no one else is
> able to work on it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
