Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1200#discussion_r102357395
--- Diff: lib/java/test/org/apache/thrift/test/TestServer.java ---
@@ -190,7 +193,9 @@ public static void main(String [] args) {
if (protocol_type.equals("binary")) {
} else if (protocol_type.equals("compact")) {
} else if (protocol_type.equals("json")) {
- } else if (protocol_type.equals("multiplexed")) {
+ } else if (protocol_type.equals("multi")) {
--- End diff --
I did it this way to work within the spec:impl naming convention that
currently exists in make cross. See tests.json, specifically "binary:accel" or
"compact:accelc". I wanted to follow the pattern that already existed in the
test suite so we have a single use pattern, not two. In the end the behavior
is mostly the same, except by using "multi:binary" on the java server and
"binary:multi" on the c_glib client, we end up testing: c_glib (binary client)
=> java (multi server) as well as c_glib (multi client wrapping binary) => java
(multi server wrapping binary). Using the "multiplexed-binary" naming
convention would not have leveraged the existing logic in crosstest/collect.py
to make this happen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
