Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1200#discussion_r102412439
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol.c ---
@@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint
property_id,
switch (property_id)
{
case PROP_THRIFT_PROTOCOL_TRANSPORT:
- protocol->transport = g_value_get_object (value);
--- End diff --
Ok. As long as the reference count is guaranteed to be well managed. And it
seems because you added the finalize method it should be okay. But I think this
breaks RAII. Since the application can get the resource and free it but the
resource will outlive the requester inside this class. But I come from C/C++
and maybe RAII doesn't apply quite well here because the reference counter. I
will study about it a little bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
