Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794199
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const { return key_; }
- enum e_req { T_REQUIRED, T_OPTIONAL, T_OPT_IN_REQ_OUT };
+ enum e_req : unsigned { T_REQUIRED, T_OPTIONAL, T_OPT_IN_REQ_OUT };
--- End diff --
Got it. Should I add a new patch to this pull request or squash them into
one patch on this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
