Github user jbapple-cloudera commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1214#discussion_r106796226
  
    --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c 
---
    @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)
     static guint64
     i64_to_zigzag (const gint64 l)
     {
    -  return (l << 1) ^ (l >> 63);
    --- End diff --
    
    You can read more about zigzag encoding here: 
https://developers.google.com/protocol-buffers/docs/encoding#types


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to