Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061917
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix undefined vptr behavior and turn this option back on.
-export CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined
-fno-sanitize=vptr"
--- End diff --
We'll still want to include `-fno-sanitize-recover=undefined`, I think.
When that option is set, a binary will crash on undefined behavior. When it is
not set, the binary will print an error and continue.
Having it set is preferable, I think, so that undefined behavior causes the
tests to fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
