Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108063510
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix undefined vptr behavior and turn this option back on.
-export CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined
-fno-sanitize=vptr"
--- End diff --
I should have been more explicit. For finding `vptr` errors, it's good to
remove `-fno-sanitize-recover=undefined`. But for checking that there are none,
it's good to have `-fno-sanitize-recover=undefined`.
If this patch fixes some, but not all, of the `vptr` errors, I would
suggest leaving `CFLAGS` as it is in `master`. If it fixes all `vptr` errors, I
think the way you have it now is optimal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
