[
https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956905#comment-15956905
]
ASF GitHub Bot commented on THRIFT-4166:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1237
THRIFT-4166: fix recent VC2010 build regression and prevent it in the
future with appveyor
I added a MSVC 2010, x86, debug, boost-1.54, python-2.7, qt-5.6 appveyor
job to prevent this from happening again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1237
----
commit d8bfc0d0d283c38c918d10bd22b5a3391961a9b4
Author: James E. King, III <jim.k...@simplivity.com>
Date: 2017-04-04T19:30:32Z
THRIFT-4166: fix recent VC2010 build regression and prevent it in the future
----
> Recent fix to remove boost::lexical_cast usage broke VS2010
> -----------------------------------------------------------
>
> Key: THRIFT-4166
> URL: https://issues.apache.org/jira/browse/THRIFT-4166
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.11.0
> Environment: VS2010
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> Removal of boost::lexical_cast and replaced with code that calls
> std::log10(2). std::log10(2) is ambiguous to VS2010.
> # Fix build breakage
> # add VS2010 32-bit build job to Appveyor to prevent future regression.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
