[ 
https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958852#comment-15958852
 ] 

ASF GitHub Bot commented on THRIFT-4166:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1237


> Recent fix to remove boost::lexical_cast usage broke VS2010
> -----------------------------------------------------------
>
>                 Key: THRIFT-4166
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4166
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.11.0
>         Environment: VS2010
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Removal of boost::lexical_cast and replaced with code that calls 
> std::log10(2).  std::log10(2) is ambiguous to VS2010.
> # Fix build breakage
> # add VS2010 32-bit build job to Appveyor to prevent future regression.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to