GitHub user dcelasun opened a pull request:

    https://github.com/apache/thrift/pull/1382

    THRIFT-4285 Move TX/RX methods from gen. code to library

    This change removes a lot of duplication from generated code and allows the 
caller to customize how they can read from / write to the transport.
    
    This patch was originally written by [Chris 
Bannister](https://issues.apache.org/jira/browse/THRIFT-4285) but it seemed 
abandoned and no longer applied cleanly to master. I fixed it in order to get 
things moving again.
    
    I've also bumped `Dockerfile`s to Go 1.9 since `t.Run` in `testing/T` 
doesn't exist before that and we were already using 1.9 for the CentOS 
container.
    
    It would be great if this can be merged before 0.11 is tagged.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dcelasun/thrift THRIFT-4285

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1382
    
----

----


---

Reply via email to