Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1382
  
    @jeking3 All tests green. I've reverted all the Go version changes and made 
the tests compatible with Go 1.4.
    
    I've also tested Thrift from this branch (both compiler and lib) with a 
large, real project and everything works fine. Here's what I had to change:
    
    IDL:
    ```thrift
    package mypkg
    
    service Foo {}
    ```
    
    Old code:
    ```go
    client := mypkg.NewFooClientFactory(transport, protocolFactory)
    ```
    
    New code:
    ```go
    protocol := protocolFactory.GetProtocol(transport)
    client := mypkg.NewFooClient(thrift.NewTStandardClient(p, p))
    ```
    
    That's it. There are other BC breaks on `master`, but this is the only 
change needed for this patch.
    
    If you are happy with it as well, I can squash and rebase from master.


---

Reply via email to