Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Some initial thoughts, before I review all of the files individually: 1. Please squash. 2. Please add [THRIFT-82] at the beginning of the commit description and the pull request description. 3. Please review https://thrift.apache.org/docs/HowToContribute. I resurrected https://issues.apache.org/jira/browse/THRIFT-82 upon seeing this. I'll start going through the files.
---