Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1410#discussion_r148790488
  
    --- Diff: lib/cl/externals/software/alexandria-20170830-git/.boring ---
    @@ -0,0 +1,13 @@
    +# Boring file regexps:
    --- End diff --
    
    If you checked in alexandria, it should not be part of the submission.  
Instead, the build process should install it on demand in the same manner that 
the nodejs implementation calls npm to install packages during the build.


---

Reply via email to