Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148797018
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareClientCallReply(protocol, i, err) {
return
}
- client := errortest.NewErrorTestClientProtocol(transport,
protocol, protocol)
+ client :=
errortest.NewErrorTestClient(thrift.NewTStandardClient(protocol, protocol))
--- End diff --
No, it's backwards compatible now (see
[here](https://github.com/dcelasun/thrift/blob/555efe5aefe9619a900471e56e86906d40bc96b9/compiler/cpp/src/thrift/generate/t_go_generator.cc#L1889-L1930)),
the test simply uses the new method.
I've also tested it with the integration of tests of a real, production
app. It works as expected.
---
