Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808675
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
if !prepareClientCallReply(protocol, i, err) {
return
}
- client := errortest.NewErrorTestClientProtocol(transport,
protocol, protocol)
+ client :=
errortest.NewErrorTestClient(thrift.NewTStandardClient(protocol, protocol))
--- End diff --
Good point :) I'll add both, but it'll have to wait till tomorrow as I've
already left the office.
---
