[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237714#comment-16237714
]
ASF GitHub Bot commented on THRIFT-4285:
----------------------------------------
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808724
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -221,3 +221,4 @@ ENV THRIFT_ROOT /thrift
RUN mkdir -p $THRIFT_ROOT/src
COPY Dockerfile $THRIFT_ROOT/
WORKDIR $THRIFT_ROOT/src
+
--- End diff --
My bad, will revert this as well.
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Priority: Major
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch,
> 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
