[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237645#comment-16237645 ]
ASF GitHub Bot commented on THRIFT-4285: ---------------------------------------- Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1382#discussion_r148793389 --- Diff: lib/go/test/tests/client_error_test.go --- @@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) { if !prepareClientCallReply(protocol, i, err) { return } - client := errortest.NewErrorTestClientProtocol(transport, protocol, protocol) + client := errortest.NewErrorTestClient(thrift.NewTStandardClient(protocol, protocol)) --- End diff -- Does this means the change is still not backwards compatible with previously written customer code? > Pull generated send/recv into library to allow behaviour to be customised > ------------------------------------------------------------------------- > > Key: THRIFT-4285 > URL: https://issues.apache.org/jira/browse/THRIFT-4285 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler, Go - Library > Reporter: Chris Bannister > Assignee: Chris Bannister > Priority: Major > Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch, > 0001-go-pull-generated-send-recv-into-lib-v7.patch > > > Currently it is difficult to change how thrift writes messages onto the > transport because they are in the generated code. Instead the generated > send/recv methods should be in the library. This will greatly simplify the > client code and remove many duplicate methods whilst allowing users more > flexibility to implement connection pools and other features such as THeader. -- This message was sent by Atlassian JIRA (v6.4.14#64029)