Github user uint commented on the issue:

    https://github.com/apache/thrift/pull/1412
  
    @jeking3 I'm really sorry, I only noticed there were suggested changes 
attached to your comment after I did a force push. I can't see them anymore. Do 
you remember if there was anything important there?
    
    I removed the CL Thrift library and made it so that it's downloaded during 
the building process. I think all the code that is left is either written by us 
(cross-tests, tutorial, build integration, etc.) or isn't an issue (code 
generator).
    
    Currently we download the library from our fork of Anderson's work by 
downloading (curl) the zip file from github and unzipping it. The long-term 
goal, though, is to merge our fork with upstream and get it added to quicklisp. 
After that we can just download the library in a similar way we download all 
the dependencies.
    
    I used that suggested bash snippet from the closed PR. It worked nicely.
    
    What do you think? Is this PR fine in its current shape?


---

Reply via email to