GitHub user Alex-Vol opened a pull request:
https://github.com/apache/thrift/pull/1468
Thrift 4259: Thrift does not compile due to Ant Maven task errors
This pull request changes the build system used to Gradle. The integration
uses the recommended and popular option of the Gradle Wrapper to avoid locking
the build to the backported versions of Gradle in the Debian repositories.
Their respective versions are varying significantly from Ubuntu release to
release and cause problems with respect to the more advanced features such as
the Maven publication.
With this change the Java library should be buildable on all platforms that
support Java and have a usable installation of the tools required.
There are still a few details to iron out such as the build integration
with the remaining Ant based projects that make build references to the results
of the Java build. These have preset expectations on the internal build
locations for the project and will have to be adjusted accordingly.
The code builds and passes all unit tests including the manual
client-server tests that were baked into the Ant build originally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Alex-Vol/thrift THRIFT-4259
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1468
----
commit 4fa3d4d12043464928d88d8bca51c64d8d7b3ec8
Author: Alex Volanis <alexander.volanis@...>
Date: 2018-01-13T20:04:22Z
THRIFT-4259: Add Gradle 4.4.1 Wrapper artifacts to enable builds
Using the Gradle Wrapper helps normalize the builds on all platforms
so we use a consistent build tool independent of package managers.
commit 931c659ab62b2a0eef653883cdaf1a25ceeb134b
Author: Alex Volanis <alexander.volanis@...>
Date: 2018-01-13T23:21:01Z
THRIFT-4259: New Gradle based build system for Java
This is now hooked into CMake and Autoconf processing steps
and can build/test/publish to Maven. The README.md was updated
to illustrate the new build options and add some documentation
on the requirements for Maven publication.
Still to do are changes for the three subprojects that have a
dependency to this project's build results. fb303, js, and as3
all seem to make references to the build artifacts from this
project which is an unfortunate entanglement.
==============================================================
The original build.xml and build.properties are still here for
reference but by the time this is fully integrated I plan to
delete them to avoid confusion.
commit e1630d186944c9f1d9a86f1fde9750fa43c06819
Author: Alex Volanis <alexander.volanis@...>
Date: 2018-01-13T20:01:43Z
THRIFT-4259: Fix two minor issues in Javadoc and unit test
Return values were undeclared in Javadoc
Test was asserting on the wrong test object instance
----
---
