[
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326776#comment-16326776
]
ASF GitHub Bot commented on THRIFT-4460:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1472
THRIFT-4460: PHP Library use PSR-2
ref https://issues.apache.org/jira/browse/THRIFT-4460
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift psr-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit ee05eef38042bb462294055c084a382f0b93328b
Author: Robert Lu <robberphex@...>
Date: 2017-11-03T04:27:31Z
reduce php library directory depth
commit cebbf0468c33080c3de6cc3b34772d1fe9a59886
Author: Robert Lu <robberphex@...>
Date: 2018-01-15T11:03:13Z
5.5.9
commit 63cf9186ecc8e7f97130ebcbabb0c61080722bce
Author: Robert Lu <robberphex@...>
Date: 2017-11-11T01:08:25Z
add php_codesniffer
* ignore composer.lock and vendor
commit feea9044270124ec88f1cf92dfad90de553ac8a1
Author: Robert Lu <robberphex@...>
Date: 2018-01-15T12:31:14Z
add php to sca
commit fc6e42109b7910e42e86b40def0158c707911ddd
Author: Robert Lu <robberphex@...>
Date: 2018-01-15T12:31:44Z
psr2 format
commit 21aeabb8088db59cb4bf8dcc30499335040fb911
Author: Robert Lu <robberphex@...>
Date: 2018-01-16T05:32:35Z
add coding_standards.md
----
> php library use PSR-2
> ---------------------
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
